-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Styles: Remove obsolete hook resolving shared block style variations #62808
Global Styles: Remove obsolete hook resolving shared block style variations #62808
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -255 B (-0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in my testing:
Kapture.2024-06-25.at.13.28.47.mp4
0e58bd7
to
66e1396
Compare
…ations (#62808) Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org>
I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: c0bbeb2 |
…ations (#62808) Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org>
What?
This PR removes an obsolete hook:
useResolvedBlockStyleVariationsConfig
Why?
With the recent shift from
styles.blocks.variations
tostyles.variations
in #62712, theuseResolvedBlockStyleVariationsConfig
no longer had an effect and isn't required for a couple of reasons:How?
useResolvedBlockStyleVariationsConfig
Testing Instructions
register_block_style
(example partial snippet below)styles.variations